Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rev notifications on publish pending #2916

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix: rev notifications on publish pending #2916

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions aries_cloudagent/revocation/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,7 @@ async def publish_pending_revocations(
if limit_crids:
crids = crids.intersection(limit_crids)
if crids:
crids = list(crids)
(delta_json, failed_crids) = await issuer.revoke_credentials(
issuer_rr_rec.cred_def_id,
issuer_rr_rec.revoc_reg_id,
Expand Down Expand Up @@ -294,6 +295,9 @@ async def publish_pending_revocations(
)
else:
rev_entry_resp = await issuer_rr_upd.send_entry(self._profile)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before I removed this it had a if not connection_id: statement on this. I think that's partly what confused me initially before I got more familiar with the flow.

await notify_revocation_published_event(
self._profile, issuer_rr_rec.revoc_reg_id, crids
)
published = sorted(crid for crid in crids if crid not in failed_crids)
result[issuer_rr_rec.revoc_reg_id] = published

Expand Down