Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing VC-DI/LD-Proof verification method option #2867

Conversation

PatStLouis
Copy link
Contributor

I replaced the custom IssuanceOptionsSchema schema on the vc/issue endpoint with the previous LDProofOptionsSchema. The idea will be to revisit the idea of having custom options field for different endpoints in a post 1.0 version. The verificationMethod option is necessary when issuing using unconventional did methods, such as did:web where the wallet can't correlate a verificationMethod with a specific did

Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@PatStLouis
Copy link
Contributor Author

@dbluhm @jamshale this should be a fairly straight forward review. For a refresher, on the vc-api issuance endpoints, if the controller doesn't provide a proofType, it will default to Ed25519Signature2020 or BbsBlsSignature2020 depending on the key method of the did.

@swcurran swcurran merged commit 68beafd into openwallet-foundation:main Apr 3, 2024
8 checks passed
@swcurran swcurran changed the title Add missing verificaiton method option Add missing VC-DI/LD-Proof verification method option Apr 3, 2024
@PatStLouis PatStLouis deleted the pstlouis/add-missing-verificaiton-method-option branch May 27, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants