Fix run_tests script #2866
Merged
Fix run_tests script #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Costanzo <[email protected]>
|
|
Ah, shoot. Sorry about that. This change fixed a minor annoyance in my environment and I incorrectly assumed that it would work in more "traditional" docker environments. |
dbluhm
approved these changes
Apr 2, 2024
|
Thanks @ianco ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a change that I think @dbluhm did awhile back, which is now causing issues when trying to run tests locally.
@dbluhm what was the reason for the fix? This PR removes your change but maybe there is an alternative that addresses your reasons without breaking local tests ...