Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase promote did retries #2854

Merged

Conversation

jamshale
Copy link
Contributor

Doh! I think I must have accidentally deleted the wait in between retries somehow and not noticed.

Hopefully this should prevent the errors during promote did.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jamshale jamshale merged commit 6da07c6 into openwallet-foundation:main Mar 22, 2024
7 of 8 checks passed
@swcurran
Copy link
Contributor

Test fail is super interesting — a CredDef that is attempting to be published fails because it already exists on the ledger. I checked the ledger and N1LoA9rMwyskHEW9csYpQJ:3:CL:360946:Faber.agent.Schema_DriversLicense_v2 was created on Feb. 16 — http://test.bcovrin.vonx.io:3707/tx/BCOVRIN_TEST/domain/360950.

How does that happen? That means that the DID being used in the test was the same as being used on Feb. 16.

🤯

@jamshale
Copy link
Contributor Author

Test fail is super interesting — a CredDef that is attempting to be published fails because it already exists on the ledger. I checked the ledger and N1LoA9rMwyskHEW9csYpQJ:3:CL:360946:Faber.agent.Schema_DriversLicense_v2 was created on Feb. 16 — http://test.bcovrin.vonx.io:3707/tx/BCOVRIN_TEST/domain/360950.

How does that happen? That means that the DID being used in the test was the same as being used on Feb. 16.

🤯

That's the other fail I've seen. Not as often.

Feb 16. That doesn't make any sense???

@swcurran
Copy link
Contributor

The only thing I can think of is that the same seed for the DID was generated on both test runs. Is it possible we’re not being random enough when coming up with the seed?

@jamshale
Copy link
Contributor Author

I just had another fail like this 69HTqHL7PjCS8K4Bp44g46:3:CL:293648:Faber.agent.Schema_DriversLicense_v2 from Jan 29. Seems like the tests must be recreating the same dids :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants