Allow for crids in event payload to be integers #2819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jamshale <[email protected]>
jamshale
force-pushed
the
revocation-notification
branch
from
ff3a425 to
ea85255
Compare
|
ianco
approved these changes
Feb 29, 2024
gvelez17
pushed a commit
to Whats-Cookin/aries-cloudagent-python
that referenced
this pull request
Mar 8, 2024
…n#2819) Signed-off-by: jamshale <[email protected]>
gvelez17
pushed a commit
to Whats-Cookin/aries-cloudagent-python
that referenced
this pull request
Mar 25, 2024
…n#2819) Signed-off-by: jamshale <[email protected]> Signed-off-by: Golda Velez <[email protected]>
gvelez17
pushed a commit
to Whats-Cookin/aries-cloudagent-python
that referenced
this pull request
Mar 25, 2024
…n#2819) Signed-off-by: jamshale <[email protected]> Signed-off-by: Golda Velez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The revocation notification not sending ended up being a simple bug. The crids from the ledger response was a list of integers but the list comprehension statement was expecting strings as thats what it gets from the wallet. I solved this by converting the list to strings to allow the payload to send integers. Think this is slightly better then making sure everywhere that ever uses this event handler is sending strings. Also added a bit better logging.
One thing I noticed is that both v1 and v2 handlers are both handling the same event. The first handler (v1 is loaded first) deletes the record so the v2 won't send the message. Not sure if this is what we want or not. Also the v1 wasn't using the
revocation.notifyconfig. So that is a bug as well I think. I changed v1 to recognize that config now.Ran into a lot of things with testing traction locally against new acapy changes.