Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change middleware registration order #2796

Merged
merged 8 commits into from
Feb 19, 2024
Merged

Change middleware registration order #2796

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6401d8c
change middleware registration order
PatStLouis Feb 16, 2024
5f4858a
lint me alone!
PatStLouis Feb 16, 2024
2f92b4d
shorten comment
PatStLouis Feb 16, 2024
9a3ec90
linting again...
PatStLouis Feb 17, 2024
4ae1714
Merge branch 'hyperledger:main' into pstlouis/change-validation-middl…
PatStLouis Feb 17, 2024
b59ec5b
Merge branch 'main' into pstlouis/change-validation-middleware-order
PatStLouis Feb 17, 2024
d4b5f90
Merge branch 'main' into pstlouis/change-validation-middleware-order
PatStLouis Feb 17, 2024
3f81e24
Merge branch 'main' into pstlouis/change-validation-middleware-order
PatStLouis Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion aries_cloudagent/admin/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ def _matches_additional_routes(self, path: str) -> bool:
async def make_application(self) -> web.Application:
"""Get the aiohttp application instance."""

middlewares = [ready_middleware, debug_middleware, validation_middleware]
middlewares = [ready_middleware, debug_middleware]

# admin-token and admin-token are mutually exclusive and required.
# This should be enforced during parameter parsing but to be sure,
Expand Down Expand Up @@ -453,6 +453,9 @@ async def setup_context(request: web.Request, handler):

middlewares.append(setup_context)

# Register validation_middleware last avoiding unauthorized validations
middlewares.append(validation_middleware)

app = web.Application(
middlewares=middlewares,
client_max_size=(
Expand Down