Implement B006 rule #2775
Merged
Implement B006 rule #2775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jamshale <[email protected]>
jamshale
force-pushed
the
feat/B006-rule
branch
from
2eabdfa to
4cf057e
Compare
|
jamshale
commented
Feb 12, 2024
| @@ -60,6 +61,8 @@ async def get_wallet_profile( | |||
| Profile: Profile for the wallet record | |||
|
|
|||
| """ | |||
| extra_settings = extra_settings or {} | |||
|
|
|||
There was a problem hiding this comment.
The extra_settings dict is overridden later in this function. I didn't want to change anything not related to the task but it seems like this might be a mistake.
jamshale
commented
Feb 12, 2024
| @@ -228,10 +228,10 @@ async def schema_get(request: web.BaseRequest): | |||
| try: | |||
| schema = await anoncreds_registry.get_schema(context.profile, schema_id) | |||
| return web.json_response(schema.serialize()) | |||
| except AnonCredsObjectNotFound: | |||
| raise web.HTTPNotFound(reason=f"Schema not found: {schema_id}") | |||
| except AnonCredsObjectNotFound as e: | |||
There was a problem hiding this comment.
I had all of the B linting rules enabled for a bit and it flagged this.
dbluhm
approved these changes
Feb 12, 2024
swcurran
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add rule
B006to the linting config and implements it by creating empty objects in the functions when the parameter is None.Didn't add any of the other
Blinting options.