Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exception on connectionless presentation problem report handler #2723

Conversation

loneil
Copy link
Contributor

@loneil loneil commented Jan 17, 2024

This is to support being able to get callbacks to vc-authn-oidc when a user declines the presentation request sent to their agent.

Presently ACA-PY is throwing an exception if the problem report does not contain a connection record.
Remove that exception and allow the recieve_problem_report to continue (and supply None for the connection ID in that case).

@loneil loneil force-pushed the feature/allowConnectionlessProofProblemReport branch from 98354f0 to 500b5f0 Compare January 17, 2024 23:29
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@jamshale jamshale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@swcurran swcurran merged commit 7c93704 into openwallet-foundation:main Jan 18, 2024
8 checks passed
@loneil loneil deleted the feature/allowConnectionlessProofProblemReport branch January 18, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants