-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable presentation issuance/verification through vc-api endpoints #2710
Enable presentation issuance/verification through vc-api endpoints #2710
Conversation
Signed-off-by: pstlouis <[email protected]>
…onality to ld_vc manager Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
The last commit added a method to store an issued VC |
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
I'm trying to re-run the failed test, as it doesn't look like it is related to this PR. You had flagged this is a [WIP], @PatStLouis , so I marked it as a "Draft" PR. Have you completed it at this point? Thanks! |
Ah...also there are conflicts with this PR to be resolved. Could you also look at that @PatStLouis ? Thanks! |
@swcurran yeah I noticed the tests were failing because it wasn't able to write a schema on the ledger which seemed odd, looks like it passed now. Let me fix the conflicts then I would consider this ready. |
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
@PatStLouis — looks like this is near ready. Can you pleae update with the base branch so we can merge it? |
Sounds good. The documentation is missing and that is a concern, so that needs to be added. |
Agree we need the documentation and we can deal with the rest in a subsequent PR. |
Sounds good, I will add this tonight, I will put a small abstract on the main readme with a link to a page in the demo folder with more information! |
…md and a postman collection in the demo folder Signed-off-by: pstlouis <[email protected]>
Head branch was pushed to by a user without write access
|
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
@dbluhm I added a manger test for the storage function |
Signed-off-by: pstlouis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with these changes!
@ianco — are your change requests ok now? |
@PatStLouis if you want to do one final merge of main, I've enabled auto merge so we can get this merged in next. |
|
This PR enables presentation issuance and verification using the vc_ld manager and addresses #2693.
There is also 4 new routes included matching the vc-api specification. (minor changes from the
/vc/ldp
endpoints, mostly key names and defaulting toEd25519Signature2018
proofType
for issuance).@dbluhm could you help me by reviewing the changes I've made to the vc_ld manager and models? You will see I added an if condition in the
verify_presentation
section to enableassertionMethod
purpose if no challenge is provided, while minimizing the impact on the existing code/workflows. I also improved the presentation models, based on the existing credential ones.I have a test instance of these changes running here.