feat: make VcLdpManager pluggable #2706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Bluhm <[email protected]>
dbluhm
force-pushed
the
feature/pluggable-vc-ldp-manager
branch
from
ea9e953 to
00f6ddc
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to #2705, this PR implements the example I gave of making
VcLdpManagerpluggable. This may be desirable to, for instance, change the issuance or verification behavior (e.g. using an external service to perform the signature or similar).This is a bit "heavier" a change than what is proposed in #2348 in the sense that it would require slightly more effort to define the alternate DID lookup mechanism but I think this would still address the same problem it was seeking to solve. Given the straightforwardness of the change required in ACA-Py to support this, I am more in favor of it being handled this way.