Ensure "preserve_exchange_records" flags are set. #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all cases on issue credential (v1 and v2) were respecting the system default. Bug on issue credential v1 where auto_remove flag was set then ignored before record saved. Signed-off-by: Jason Sherman <[email protected]>
dbluhm
approved these changes
Dec 9, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all cases on issue credential (v1 and v2) were respecting the system default.
There was a bug on issue credential v1 where
auto_removeflag was set then ignored before the record was saved.So behaviour has been tested for issue credential (v1 & v2) and proof presentation (v1 & v2); exchange records are preserved if the
--preserve-exchange-recordsistrueandauto_removehas not been set toTrueon API calls that accept it (iesend-offer,send-request).Fixes #2656