Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration tests for anoncreds-rs #2651

Merged
merged 6 commits into from
Dec 6, 2023

Conversation

ianco
Copy link
Contributor

@ianco ianco commented Dec 4, 2023

Final update from the anoncreds-rs branch, brings across some integration tests, and also includes a bit of cleanup.

@ianco ianco added the AnonCreds Ledger Agnostic AnonCreds label Dec 5, 2023
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ianco ianco marked this pull request as ready for review December 5, 2023 19:00
@swcurran
Copy link
Contributor

swcurran commented Dec 5, 2023

@ianco — failed test. Sunspots? Should we just run it again?

@ianco
Copy link
Contributor Author

ianco commented Dec 5, 2023

@ianco — failed test. Sunspots? Should we just run it again?

I'll take a look

@ianco
Copy link
Contributor Author

ianco commented Dec 5, 2023

Yah solar flares ... I've restarted the tests.

The error was:

#3/4 Create a new schema/cred def on the ledger
INFO:aiohttp.access:172.17.0.1 [05/Dec/2023:19:18:41 +0000] "POST /webhooks/topic/connections/ HTTP/1.1" 200 149 "-" "Python/3.9 aiohttp/3.9.1"
7hFaber.agent | 2023-12-05 19:18:41,997 aries_cloudagent.ledger.base WARNING Schema already exists on ledger. Returning details.
7hFaber.agent | 2023-12-05 19:18:44,109 aries_cloudagent.core.dispatcher ERROR Handler error: schemas_post
7hFaber.agent | Traceback (most recent call last):
7hFaber.agent |   File "/home/aries/aries_cloudagent/ledger/indy_vdr.py", line 372, in _submit
7hFaber.agent |     request_result = await self.pool.handle.submit_request(request)
7hFaber.agent |   File "/home/aries/.local/lib/python3.9/site-packages/indy_vdr/pool.py", line 116, in submit_request
7hFaber.agent |     result = await fut
7hFaber.agent |   File "/usr/local/lib/python3.9/asyncio/futures.py", line 284, in __await__
7hFaber.agent |     yield self  # This tells Task to wait for completion.
7hFaber.agent |   File "/usr/local/lib/python3.9/asyncio/tasks.py", line 328, in __wakeup
7hFaber.agent |     future.result()
7hFaber.agent |   File "/usr/local/lib/python3.9/asyncio/futures.py", line 201, in result
7hFaber.agent |     raise self._exception
7hFaber.agent | indy_vdr.error.VdrError: Request failed: client request invalid: UnauthorizedClientRequest('Kh9jVJcF38XNdJRxsDtWSS', 1701803921997302404, 'The action is forbidden')

... which doesn't make sense, as the DID was properly registered:

http://test.bcovrin.vonx.io:3707/tx/BCOVRIN_TEST/domain/40230

Maybe a ledger timing issue?

@swcurran swcurran merged commit 11914ec into openwallet-foundation:main Dec 6, 2023
9 checks passed
@swcurran
Copy link
Contributor

swcurran commented Dec 6, 2023

Awesome!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AnonCreds Ledger Agnostic AnonCreds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants