-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update integration tests for anoncreds-rs #2651
Merged
swcurran
merged 6 commits into
openwallet-foundation:main
from
ianco:anoncreds-rs-migrate-4
Dec 6, 2023
Merged
Update integration tests for anoncreds-rs #2651
swcurran
merged 6 commits into
openwallet-foundation:main
from
ianco:anoncreds-rs-migrate-4
Dec 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
@ianco — failed test. Sunspots? Should we just run it again? |
I'll take a look |
Yah solar flares ... I've restarted the tests. The error was:
... which doesn't make sense, as the DID was properly registered: http://test.bcovrin.vonx.io:3707/tx/BCOVRIN_TEST/domain/40230 Maybe a ledger timing issue? |
swcurran
approved these changes
Dec 6, 2023
Awesome!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final update from the
anoncreds-rs
branch, brings across some integration tests, and also includes a bit of cleanup.