Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the ReadTheDocs config in case we do another 0.10.x release #2628

Closed
wants to merge 30 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
9ccf56a
fix: unique ids for services in legacy peer
dbluhm Sep 7, 2023
c8e660c
fix: unique ids for services in legacy peer
dbluhm Sep 7, 2023
ed2c289
Merge branch '0.10.2' of https://github.com/hyperledger/aries-cloudag…
shaangill025 Sep 7, 2023
468f1e3
fix issue_2477
shaangill025 Sep 7, 2023
635d25e
Merge pull request #2482 from shaangill025/0.10.2_release
swcurran Sep 7, 2023
0e9715f
0.10.2
swcurran Sep 8, 2023
b4a679f
Update version.py
swcurran Sep 8, 2023
8aa222d
Update openapi.json for 0.10.2-rc0
swcurran Sep 8, 2023
9a30926
Update swagger.json for 0.10.2-rc0
swcurran Sep 8, 2023
b4072ff
Merge pull request #2484 from hyperledger/swcurran-0.10.2
swcurran Sep 8, 2023
ef5cf51
fix: update pydid
dbluhm Sep 21, 2023
44d5371
fix: pin typing extensions to workaround known issue
dbluhm Sep 21, 2023
a22fe5a
Merge pull request #2500 from dbluhm/0.10.2
swcurran Sep 22, 2023
0d0fce4
0.10.2
swcurran Sep 22, 2023
89f9fdc
Merge pull request #2509 from swcurran/0.10.2
swcurran Sep 22, 2023
ef24ed1
parent 49e71c8aae319c7d805160696fecb1bcb85f139d
shaangill025 Sep 8, 2023
038b632
0.10.3
swcurran Sep 29, 2023
736cdfb
Merge pull request #2522 from swcurran/0.10.3
swcurran Sep 29, 2023
70449f5
Fixed: https://github.com/hyperledger/aries-cloudagent-python/issues/…
codespree Oct 7, 2023
07d5d7e
style: minor style correction
dbluhm Oct 7, 2023
726de09
test: did:key to did:key ref
dbluhm Oct 7, 2023
f498219
fix: remove redundant transform step
dbluhm Oct 7, 2023
c5d16ed
Merge pull request #2537 from dbluhm/fix/routing-keys-backport
dbluhm Oct 8, 2023
fc350f9
0.10.4
swcurran Oct 9, 2023
9ce2e5a
Merge pull request #2539 from swcurran/0.10.4
swcurran Oct 9, 2023
1b8baa9
fix: report presentation result
dbluhm Nov 20, 2023
6512f9a
fix: challenge from request always
dbluhm Nov 21, 2023
4c45244
Merge pull request #2622 from dbluhm/backport/fix/presentations-resul…
swcurran Nov 21, 2023
0c3745f
0.10.5
swcurran Nov 21, 2023
999eade
Update the ReadTheDocs config in case we do another 0.10.x release
swcurran Nov 25, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .readthedocs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,7 @@ build:
sphinx:
builder: dirhtml
configuration: docs/conf.py

python:
install:
- requirements: docs/requirements.txt
106 changes: 104 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,105 @@
# 0.10.5

## November 21, 2023

Release 0.10.5 is a high priority patch release to correct an issue with the
handling of the JSON-LD presentation verifications, where the status of the
verification of the `presentation.proof` in the Verifiable Presentation was not
included when determining the verification value (`true` or `false`) of the
overall presentation. A forthcoming security advisory will cover the details.

Anyone using JSON-LD presentations is recommended to upgrade to this version
of ACA-Py as soon as possible.

### 0.10.5 Categorized List of Pull Requests

- JSON-LD Credential Exchange (Issue, Present) Updates
- fix(backport): report presentation result [\#2622](https://github.com/hyperledger/aries-cloudagent-python/pull/2622) [dbluhm](https://github.com/dbluhm)
- Release management pull requests
- 0.10.5 [\#2623](https://github.com/hyperledger/aries-cloudagent-python/pull/2623) [swcurran](https://github.com/swcurran)

# 0.10.4

## October 9, 2023

Release 0.10.4 is a patch release to correct an issue with the handling of `did:key` routing
keys in some mediator scenarios, notably with the use of [Aries Framework Kotlin]. See the
details in the PR and [Issue \#2531 Routing for agents behind a aca-py based mediator is broken].

Thanks to [codespree](https://github.com/codespree) for raising the issue and providing the fix.

[Aries Framework Kotlin](https://github.com/hyperledger/aries-framework-kotlin)
[Issue \#2531 Routing for agents behind a aca-py based mediator is broken]: https://github.com/hyperledger/aries-cloudagent-python/issue/2531

### 0.10.4 Categorized List of Pull Requests

- DID Handling and Connection Establishment Updates/Fixes
- fix: routing behind mediator [\#2536](https://github.com/hyperledger/aries-cloudagent-python/pull/2536) [dbluhm](https://github.com/dbluhm)
- Release management pull requests
- 0.10.4 [\#2539](https://github.com/hyperledger/aries-cloudagent-python/pull/2539) [swcurran](https://github.com/swcurran)

# 0.10.3

## September 29, 2023

Release 0.10.3 is a patch release to add an upgrade process for very old
versions of Aries Cloud Agent Python (circa [0.5.2](#052)). If you have a long
time deployment of an issuer that uses revocation, this release could correct
internal data (tags in secure storage) related to revocation registries.
Details of the about the triggering problem can be found in [Issue \#2485].

[Issue \#2485]: https://github.com/hyperledger/aries-cloudagent-python/issue/2485

The upgrade is applied by running the following command for the ACA-Py
instance to be upgraded:

`./scripts/run_docker upgrade --force-upgrade --named-tag fix_issue_rev_reg`

### 0.10.3 Categorized List of Pull Requests

- Credential Exchange (Issue, Present) Updates
- Feat: Upgrade from tags and fix issue with legacy IssuerRevRegRecords [<=v0.5.2] [\#2486](https://github.com/hyperledger/aries-cloudagent-python/pull/2486) [shaangill025](https://github.com/shaangill025)
- Release management pull requests
- 0.10.3 [\#2522](https://github.com/hyperledger/aries-cloudagent-python/pull/2522) [swcurran](https://github.com/swcurran)

# 0.10.2

## September 22, 2023

Release 0.10.2 is a patch release for 0.10.1 that addresses three specific regressions found
in deploying Release 0.10.1. The regressions are to fix:

- An ACA-Py instance upgraded to 0.10.1 that had an existing connection to another Aries agent
where the connection has both an `http` and `ws` (websocket) service endpoint with the same ID cannot
message that agent. A scenario is an ACA-Py issuer connecting to an Endorser with both `http` and
`ws` service endpoints. The updates made in 0.10.1 to improve ACA-Py DID resolution did not account
for this scenario and needed a tweak to work ([Issue \#2474], [PR \#2475]).
- The "fix revocation registry" endpoint used to fix scenarios an Issuer's local revocation registry
state is out of sync with the ledger was broken by some code being added to support a single
ACA-Py instance writing to different ledgers ([Issue \#2477], [PR \#2480]).
- The version of the [PyDID] library we were using did not handle some
unexpected DID resolution use cases encountered with mediators. The PyDID
library version dependency was updated in [PR \#2500].

[Issue \#2474]: https://github.com/hyperledger/aries-cloudagent-python/issue/2474
[PR \#2475]: https://github.com/hyperledger/aries-cloudagent-python/pull/2476
[Issue \#2477]: https://github.com/hyperledger/aries-cloudagent-python/issue/2477
[PR \#2480]: https://github.com/hyperledger/aries-cloudagent-python/pull/2480
[PyDID]: https://github.com/sicpa-dlab/pydid
[PR \#2500]: https://github.com/hyperledger/aries-cloudagent-python/pull/2500

### 0.10.2 Categorized List of Pull Requests

- DID Handling and Connection Establishment Updates/Fixes
- LegacyPeerDIDResolver: erroneously assigning same ID to multiple services [\#2475](https://github.com/hyperledger/aries-cloudagent-python/pull/2475) [dbluhm](https://github.com/dbluhm)
- fix: update pydid [\#2500](https://github.com/hyperledger/aries-cloudagent-python/pull/2500) [dbluhm](https://github.com/dbluhm)
- Credential Exchange (Issue, Present) Updates
- Bugfix: Issue with write ledger pool when performing Accumulator sync [\#2480](https://github.com/hyperledger/aries-cloudagent-python/pull/2480) [shaangill025](https://github.com/shaangill025)
- Release management pull requests
- 0.10.2 [\#2509](https://github.com/hyperledger/aries-cloudagent-python/pull/2509) [swcurran](https://github.com/swcurran)
- 0.10.2-rc0 [\#2484](https://github.com/hyperledger/aries-cloudagent-python/pull/2484) [swcurran](https://github.com/swcurran)
- 0.10.2 Patch Release - fix issue #2475, #2477 [\#2482](https://github.com/hyperledger/aries-cloudagent-python/pull/2480) [shaangill025](https://github.com/shaangill025)

# 0.10.1

## August 29, 2023
Expand Down Expand Up @@ -60,7 +162,7 @@ deleted from ACA-Py storage.

[\#2352]: https://github.com/hyperledger/aries-cloudagent-python/pull/2352

### 0.10.0 Categorized List of Pull Requests
### 0.10.1 Categorized List of Pull Requests

- DIDComm Messaging Improvements/Fixes
- fix: outbound send status missing on path [\#2393](https://github.com/hyperledger/aries-cloudagent-python/pull/2393) [dbluhm](https://github.com/dbluhm)
Expand Down Expand Up @@ -112,7 +214,7 @@ deleted from ACA-Py storage.

## August 29, 2023

Release 0.10.1 has the same contents as 0.10.0. An error on PyPi prevented the
Release 0.10.0 has the same contents as 0.10.1. An error on PyPi prevented the
0.10.0 release from being properly uploaded because of an existing file of the
same name. We immediately released 0.10.1 as a replacement.

Expand Down
19 changes: 19 additions & 0 deletions UpgradingACA-Py.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,25 @@ is high (such as a "resave connections" upgrade to a deployment with many, many
connections), you may want to do a test upgrade offline first, to see if there
is likely to be a service disruption during the upgrade. Plan accordingly!

## Tagged upgrades
Upgrades are defined in the [Upgrade Definition YML file], in addition to specifying upgrade actions by version they can also be specified by named tags. Unlike version based upgrades where all applicable version based actions will be performed based upon sorted order of versions, with named tags only actions corresponding to provided tags will be performed. Note: `--force-upgrade` is required when running name tags based upgrade [i.e. provding `--named-tag`]

Tags are specfied in YML file as below:
```
fix_issue_rev_reg:
fix_issue_rev_reg_records: true
```

Example
```
./scripts/run_docker upgrade --force-upgrade --named-tag fix_issue_rev_reg

In case, running multiple tags [say test1 & test2]:
./scripts/run_docker upgrade --force-upgrade --named-tag test1 --named-tag test2
```



## Exceptions

There are a couple of upgrade exception conditions to consider, as outlined
Expand Down
4 changes: 3 additions & 1 deletion aries_cloudagent/commands/default_version_upgrade_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,6 @@ v0.7.1:
v0.7.0:
update_existing_records: false
v0.6.0:
update_existing_records: false
update_existing_records: false
fix_issue_rev_reg:
fix_issue_rev_reg_records: true
42 changes: 41 additions & 1 deletion aries_cloudagent/commands/tests/test_upgrade.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,44 @@ async def test_upgrade_callable(self):
}
)

async def test_upgrade_callable_named_tag(self):
version_storage_record = await self.storage.find_record(
type_filter="acapy_version", tag_query={}
)
await self.storage.delete_record(version_storage_record)
with async_mock.patch.object(
test_module,
"wallet_config",
async_mock.CoroutineMock(
return_value=(
self.profile,
async_mock.CoroutineMock(did="public DID", verkey="verkey"),
)
),
), async_mock.patch.object(
test_module.yaml,
"safe_load",
async_mock.MagicMock(
return_value={
"v0.7.2": {
"resave_records": {
"base_record_path": [
"aries_cloudagent.connections.models.conn_record.ConnRecord"
]
},
"update_existing_records": True,
},
"fix_issue_rev_reg": {"fix_issue_rev_reg_records": True},
}
),
):
await test_module.upgrade(
settings={
"upgrade.named_tags": ["fix_issue_rev_reg"],
"upgrade.force_upgrade": True,
}
)

async def test_upgrade_x_same_version(self):
version_storage_record = await self.storage.find_record(
type_filter="acapy_version", tag_query={}
Expand Down Expand Up @@ -170,7 +208,9 @@ async def test_upgrade_missing_from_version(self):
"upgrade.config_path": "./aries_cloudagent/commands/default_version_upgrade_config.yml",
}
)
assert "No upgrade from version found in wallet or" in str(ctx.exception)
assert "Error during upgrade: No upgrade from version or tags found" in str(
ctx.exception
)

async def test_upgrade_x_callable_not_set(self):
version_storage_record = await self.storage.find_record(
Expand Down
Loading