-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Per Tenant Logging #2550
Feat: Per Tenant Logging #2550
Conversation
shaangill025
commented
Oct 17, 2023
•
edited
Loading
edited
- resolve Test Per Tenant Log Access and expand out #2359
- Derived from work done in Per Tenant Logging - Complete Implementation #2425
- Needed to close that PR as the pre-release images in there somehow included legacy code which was removed subsequently.
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
@WadeBarnes Can you please create a pre-release image for this PR. |
aries_cloudagent/protocols/coordinate_mediation/v1_0/handlers/tests/test_keylist_handler.py
Outdated
Show resolved
Hide resolved
@shaangill025, based on the testing, it looks like you'll need to update the logging to default to |
Signed-off-by: Shaanjot Gill <[email protected]>
…t-python into feat_per_tenant_logging
Signed-off-by: Shaanjot Gill <[email protected]>
…t-python into feat_per_tenant_logging
Signed-off-by: Shaanjot Gill <[email protected]>
…t-python into feat_per_tenant_logging
Signed-off-by: Shaanjot Gill <[email protected]>
Any word on when we can look at getting the failing tests resolved? |
Signed-off-by: Shaanjot Gill <[email protected]>
…t-python into feat_per_tenant_logging Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think changes look good, I am a bit confused about having same settings (e.g.: the log file path) in both default_per_tenant_logging.ini
and default_per_tenant_logging.yaml
, but I might be missing something.
@dbluhm if you are happy with the latest tweaks we can probably merge.
Kudos, SonarCloud Quality Gate passed! |
This is about supporting both |
Awesome — thanks, @shaangill025 . Thanks for reviewing and merging @esune @dbluhm . One more to go... |