Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Per Tenant Logging #2550

Merged

Conversation

shaangill025
Copy link
Contributor

@shaangill025 shaangill025 commented Oct 17, 2023

Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
@shaangill025
Copy link
Contributor Author

@WadeBarnes Can you please create a pre-release image for this PR.

@WadeBarnes
Copy link
Contributor

@shaangill025, A prerelease image has been built; https://github.com/hyperledger/aries-cloudagent-python/pkgs/container/aries-cloudagent-python/138271403?tag=py3.9-0.11.0-pr2550-pre0

@WadeBarnes
Copy link
Contributor

@shaangill025, based on the testing, it looks like you'll need to update the logging to default to ${HOME}/log (or ./log), for example /home/aries/log/ on the askar only images. On OCP the non-privilege user can't write to ${HOME}.

dbluhm
dbluhm previously approved these changes Oct 23, 2023
@dbluhm dbluhm added this to the 0.11.0 milestone Oct 27, 2023
@dbluhm
Copy link
Contributor

dbluhm commented Nov 9, 2023

Any word on when we can look at getting the failing tests resolved?

Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changes look good, I am a bit confused about having same settings (e.g.: the log file path) in both default_per_tenant_logging.ini and default_per_tenant_logging.yaml, but I might be missing something.

@dbluhm if you are happy with the latest tweaks we can probably merge.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@shaangill025
Copy link
Contributor Author

shaangill025 commented Nov 15, 2023

I am a bit confused about having same settings (e.g.: the log file path) in both default_per_tenant_logging.ini and default_per_tenant_logging.yaml, but I might be missing something.

This is about supporting both ini (logging FileConfig) and yml (logging DictConfig) config files. Could use either one of that format.

@dbluhm dbluhm merged commit b51d988 into openwallet-foundation:main Nov 15, 2023
9 checks passed
@swcurran
Copy link
Contributor

Awesome — thanks, @shaangill025 . Thanks for reviewing and merging @esune @dbluhm .

One more to go...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Per Tenant Log Access and expand out
5 participants