Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2488 KeyError raised when Subject ID is not a URI #2490

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

Ennovate-com
Copy link
Contributor

Changed from value, which may or may not be a list, to subject, derived from subjects which is always a list.

@Ennovate-com Ennovate-com changed the title Issue #2488 KeyError raised when Subject ID is not a URI #2489 Issue #2488 KeyError raised when Subject ID is not a URI Sep 10, 2023
@dbluhm
Copy link
Contributor

dbluhm commented Sep 14, 2023

Thanks for the fix! At a glance, based on the details you provided in the issue, this seems like a pretty straightforward change. I'll take a closer look once checks complete 🙂

Signed-off-by: Robert Simpson <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dbluhm dbluhm merged commit 9e7e74a into openwallet-foundation:main Sep 14, 2023
8 checks passed
@Ennovate-com Ennovate-com deleted the fix/KeyError branch December 25, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants