Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unique ids for services in legacy peer #2476

Merged
merged 2 commits into from
Sep 7, 2023
Merged

fix: unique ids for services in legacy peer #2476

merged 2 commits into from
Sep 7, 2023

Conversation

dbluhm
Copy link
Contributor

@dbluhm dbluhm commented Sep 7, 2023

Resolves #2475.

@swcurran
Copy link
Contributor

swcurran commented Sep 7, 2023

Thanks, @dbluhm — you are awesome!! Let’s determine how best to get these three little lines into the wild!

@dbluhm dbluhm mentioned this pull request Sep 7, 2023
Closed
@swcurran
Copy link
Contributor

swcurran commented Sep 7, 2023

@usingtechnology @Jsyro — this is the PR for review. Handling old DID Docs, addressing the “can’t connect to the endorser” issue.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swcurran swcurran mentioned this pull request Sep 7, 2023
Closed
usingtechnology
usingtechnology approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@usingtechnology usingtechnology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, ran the tests locally and passed. changes seem logical.

@swcurran swcurran merged commit f189bd0 into openwallet-foundation:main Sep 7, 2023
@Jsyro
Copy link
Contributor

Jsyro commented Sep 7, 2023

Looks good!

@swcurran swcurran mentioned this pull request Sep 7, 2023
Closed
@usingtechnology usingtechnology mentioned this pull request Sep 15, 2023
Closed
@dbluhm dbluhm deleted the fix/service-endpoint-unique-ids branch January 30, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usingtechnology usingtechnology usingtechnology approved these changes

@Jsyro Jsyro Awaiting requested review from Jsyro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LegacyPeerDIDResolver: erroneously assigning same ID to multiple services
4 participants
@dbluhm @swcurran @Jsyro @usingtechnology