Revocation API using anoncreds-rs #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Sherman <[email protected]>
Signed-off-by: Jason Sherman <[email protected]>
…remove extraneous methods Signed-off-by: Jason Sherman <[email protected]>
add a revocation api to test endpoints without endorser (not yet added to anoncreds) Signed-off-by: Jason Sherman <[email protected]>
dbluhm
reviewed
Sep 18, 2023
implement endpoints used for TAA BDD tests Signed-off-by: Jason Sherman <[email protected]>
usingtechnology
changed the title
|
@dbluhm - bumping this if you have time to look over the updates since your last review. |
…ions Signed-off-by: Jason Sherman <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
thanks for the extra pair of eyes @dbluhm. tests and everything work but having the wrong methods in the base class sure would have been confusing for other implementations. |
dbluhm
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #2432.
Trim down
/revocationAPI to match up with/anoncreds/revocationAPI.Removed APIs related to
Manually Creating Revocation Entries.Updated the pytests to use
@pytest.mark.skip(reason="anoncreds-rs breaking change")instead of renaming the tests. Still need to come back to these and fix them (see issue #2433).There are remaining related issues - need to update TAA related APIs - see #2493 - but want to close this out and tackle that separately. (Update, these endpoints are now implemented/updated). Closes #2493
We will also have to discuss if we need to add back the
Manually Creating Revocation EntriesAPI as they were very handy during the IDIM reset/issues.Since we do not have endorser enabled, I simply couldn't update/use the BDD tests in
0586-sign-transaction.featureso I did hack together something similar that did not require an endorser. I ran againstmainand all the scenarios passed, but the included file has 1 scenario skipped because the Manual steps/API do not exist here.