Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Indy tests from workflows #2415

Merged
merged 5 commits into from
Aug 14, 2023

Conversation

dbluhm
Copy link
Contributor

@dbluhm dbluhm commented Aug 14, 2023

As discussed recently and captured in #2402, this PR removes Indy specific tests from PR test runs. This also adjusts other images and examples in the demo folder to use the non-indy variant of images.

swcurran
swcurran previously approved these changes Aug 14, 2023
Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — ran the Alice-Faber demo and everything worked as normal.

@swcurran
Copy link
Contributor

The indy tests are being removed, so need not pass, right? Go ahead and merge? Do we put this in 0.10.0? I think so...

@dbluhm
Copy link
Contributor Author

dbluhm commented Aug 14, 2023

Yeah, we'll have to adjust the branch protection rules to not require the Indy test any more. Also note that this PR hasn't adjusted the nightly tests yet. I could just remove those lines from the nightly test workflow file but I wondered if it would make sense to instead make it so the indy tests aren't called when run by cron but if we do a manual dispatch, maybe we could set a flag to run the indy tests if we choose. This would allow us to manually trigger tests for indy in the future if the need ever came up. Thoughts @WadeBarnes?

@WadeBarnes
Copy link
Contributor

I can adjust the branch protection rules once the PR is merged.

I'd say remove the nightly test workflow for now. We can always reinstate things later if the needs arise.

Should this PR include removal of the indy-sdk related build/publish workflows, or is that going to be a separate PR?

@swcurran
Copy link
Contributor

I’d say separate PR for the indy/sdk removal for publishing. Hold off on that for a bit.

@dbluhm
Copy link
Contributor Author

dbluhm commented Aug 14, 2023

K, I will go ahead and remove the nightly workflow for indy.

dbluhm added 5 commits August 14, 2023 14:16
And remove other problems like references to "indy" as home folder

Signed-off-by: Daniel Bluhm <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dbluhm dbluhm linked an issue Aug 14, 2023 that may be closed by this pull request
@dbluhm dbluhm changed the title Remove Indy from tests run on PRs Remove Indy tests from workflows Aug 14, 2023
@dbluhm
Copy link
Contributor Author

dbluhm commented Aug 14, 2023

This is ready to merge whenever we're ready to pull the trigger on this change @swcurran @WadeBarnes

@swcurran swcurran enabled auto-merge August 14, 2023 19:51
@swcurran swcurran disabled auto-merge August 14, 2023 19:52
@swcurran swcurran merged commit c04370b into openwallet-foundation:main Aug 14, 2023
@swcurran
Copy link
Contributor

Updated the branch protection rules to remove the Indy Test.

@dbluhm dbluhm deleted the ci/no-indy branch August 14, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Remove Indy SDK tests from the integration/nightly runs
3 participants