-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Indy tests from workflows #2415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM — ran the Alice-Faber demo and everything worked as normal.
The indy tests are being removed, so need not pass, right? Go ahead and merge? Do we put this in 0.10.0? I think so... |
Yeah, we'll have to adjust the branch protection rules to not require the Indy test any more. Also note that this PR hasn't adjusted the nightly tests yet. I could just remove those lines from the nightly test workflow file but I wondered if it would make sense to instead make it so the indy tests aren't called when run by cron but if we do a manual dispatch, maybe we could set a flag to run the indy tests if we choose. This would allow us to manually trigger tests for indy in the future if the need ever came up. Thoughts @WadeBarnes? |
I can adjust the branch protection rules once the PR is merged. I'd say remove the nightly test workflow for now. We can always reinstate things later if the needs arise. Should this PR include removal of the indy-sdk related build/publish workflows, or is that going to be a separate PR? |
I’d say separate PR for the indy/sdk removal for publishing. Hold off on that for a bit. |
K, I will go ahead and remove the nightly workflow for indy. |
Signed-off-by: Daniel Bluhm <[email protected]>
And remove other problems like references to "indy" as home folder Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
This is ready to merge whenever we're ready to pull the trigger on this change @swcurran @WadeBarnes |
Updated the branch protection rules to remove the Indy Test. |
As discussed recently and captured in #2402, this PR removes Indy specific tests from PR test runs. This also adjusts other images and examples in the demo folder to use the non-indy variant of images.