Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: outbound send status missing on path #2393

Merged
merged 2 commits into from
Aug 2, 2023
Merged

fix: outbound send status missing on path #2393

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1adf272
fix: outbound send status missing on path
dbluhm Aug 2, 2023
18447d1
Merge branch 'main' into fix/outbound-send-status-missing
swcurran Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions aries_cloudagent/core/conductor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import hashlib
import json
import logging
from typing import Optional

from packaging import version as package_version
from qrcode import QRCode
Expand Down Expand Up @@ -677,7 +678,7 @@ async def queue_outbound(
self,
profile: Profile,
outbound: OutboundMessage,
inbound: InboundMessage = None,
inbound: Optional[InboundMessage] = None,
) -> OutboundSendStatus:
"""
Queue an outbound message for transport.
Expand All @@ -700,7 +701,7 @@ async def queue_outbound(
)
except ConnectionManagerError:
LOGGER.exception("Error preparing outbound message for transmission")
return
return OutboundSendStatus.UNDELIVERABLE
except (LedgerConfigError, LedgerTransactionError) as e:
LOGGER.error("Shutdown on ledger error %s", str(e))
if self.admin_server:
Expand Down