Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keylist update response race condition #2391

Merged
merged 4 commits into from
Aug 2, 2023
Merged

fix: keylist update response race condition #2391

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db06a98
fix: save conn rec before keylist update
dbluhm Jul 31, 2023
9811395
docs: small comment on record save
dbluhm Jul 31, 2023
8b5130a
fix: emit keylist update after existing save
dbluhm Jul 31, 2023
dea39bb
Merge branch 'main' into fix/keylist-update-response-race
dbluhm Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions aries_cloudagent/protocols/didexchange/v1_0/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,12 +300,7 @@ async def create_request(
method=SOV,
key_type=ED25519,
)
conn_rec.my_did = my_info.did

# Idempotent; if routing has already been set up, no action taken
await self._route_manager.route_connection_as_invitee(
self.profile, conn_rec, mediation_record
)
conn_rec.my_did = my_info.did

# Create connection request message
if my_endpoint:
Expand Down Expand Up @@ -362,6 +357,11 @@ async def create_request(
async with self.profile.session() as session:
await conn_rec.save(session, reason="Created connection request")

# Idempotent; if routing has already been set up, no action taken
await self._route_manager.route_connection_as_invitee(
self.profile, conn_rec, mediation_record
)

return request

async def receive_request(
Expand Down