Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .indy_client folder to Askar only image. #2308

Merged

Conversation

WadeBarnes
Copy link
Contributor

Fixes #2307

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swcurran
Copy link
Contributor

@loneil — are you able to test with this updated Dockerfile?

@loneil
Copy link
Contributor

loneil commented Jul 17, 2023

@loneil — are you able to test with this updated Dockerfile?

My docker-ing is relatively weak in this area, but since we're basing on the published image
FROM ghcr.io/hyperledger/aries-cloudagent-python:py3.9-0.8.2 as base
can I import based on the change to the dockerfile in this branch/fork? Or do I need a new published/tag image?

@WadeBarnes
Copy link
Contributor Author

Once the changes are merged I can build and publish a new image (without having to do a release) for testing you could reference.

@swcurran swcurran merged commit ed7e856 into openwallet-foundation:main Jul 18, 2023
@WadeBarnes
Copy link
Contributor Author

@loneil, Here is the published image for your testing; ghcr.io/hyperledger/aries-cloudagent-python:py3.9-0.8.3-pre

@loneil
Copy link
Contributor

loneil commented Jul 18, 2023

@swcurran @WadeBarnes thanks for publishing image!
Trying with ghcr.io/hyperledger/aries-cloudagent-python:py3.9-0.8.3-pre on an OpenShift deployment I am now able to create and issue and revoke revocable credentials.
The .indy_client folder is in the pod with tails files with appropriate permissions now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to preset indy_client folder with Askar before creating Revocation Registry
3 participants