Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: route multitenant connectionless oob invitation #2243

Conversation

TimoGlastra
Copy link
Contributor

This addresses an issue where the keys used in connectionless oob invitations were not correctly set-up for routing through the base wallet when multi-tenancy is enabled, which resulted in those invitation not being usable.

cc @lohanspies @ff137

@TimoGlastra TimoGlastra requested a review from dbluhm May 26, 2023 12:49
@lohanspies
Copy link

Thank you @TimoGlastra, much appreciated

Copy link
Contributor

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good though I'm a bit confused how the added config files are used. Are they just examples? Used in testing?

Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra TimoGlastra force-pushed the fix/oob-connectionless-multitenant branch from a36e85e to d2a46b2 Compare May 27, 2023 20:52
@TimoGlastra
Copy link
Contributor Author

Those are my local config files for testing and were pushed by accident 🤦

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dbluhm dbluhm merged commit b7b62b1 into openwallet-foundation:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants