-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update webhook message to terse form by default, added startup flag --debug-webhooks for full form #2145
Update webhook message to terse form by default, added startup flag --debug-webhooks for full form #2145
Conversation
Signed-off-by: Victor Lee <[email protected]>
Signed-off-by: Victor Lee <[email protected]>
Signed-off-by: Devin Lo <[email protected]>
Signed-off-by: Devin Lo <[email protected]>
Signed-off-by: Devin Lo <[email protected]>
Signed-off-by: Devin Lo <[email protected]>
Signed-off-by: Victor Lee <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
Signed-off-by: Victor Lee <[email protected]>
178cd42
to
89fc813
Compare
Terse form webhook broke integration test where agent_container.py try to get message["by_format"] from cred exch & pres exch webhook and it no longer exist. we might want to add startup flag --debug-webhooks to the agent |
Some tests are failing, I suspect due to the terse webhook format:
(Not sure if they all have the same error, I just scanned for the first one) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Integration tests need to be updated to either configure the verbose format, or to not rely on detailed webhooks
Signed-off-by: Victor Lee <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
Related PR #1941
Addresses Issue #2136
Presentation Exchange now has dedicated webhook object.
added --debug-webhooks flag to toggle full Protocol State Object for development purpose.
removed --light-weight-webhook as it is now obsolete and refactored.
Signed-off-by: Victor Lee [email protected]