Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webhook message to terse form by default, added startup flag --debug-webhooks for full form #2145

Merged
merged 10 commits into from
Mar 6, 2023

Conversation

victorlee0505
Copy link
Contributor

Related PR #1941
Addresses Issue #2136

Presentation Exchange now has dedicated webhook object.

added --debug-webhooks flag to toggle full Protocol State Object for development purpose.

removed --light-weight-webhook as it is now obsolete and refactored.

Signed-off-by: Victor Lee [email protected]

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@victorlee0505
Copy link
Contributor Author

Terse form webhook broke integration test where agent_container.py try to get message["by_format"] from cred exch & pres exch webhook and it no longer exist.

we might want to add startup flag --debug-webhooks to the agent

@ianco
Copy link
Contributor

ianco commented Feb 28, 2023

Some tests are failing, I suspect due to the terse webhook format:

      future: <Task finished coro=<AriesAgent.handle_issue_credential_v2_0() done, defined at /home/indy/demo/runners/agent_container.py:229> exception=KeyError('by_format',)>
      Traceback (most recent call last):
        File "/home/indy/demo/runners/agent_container.py", line 249, in handle_issue_credential_v2_0
          if message["by_format"]["cred_offer"].get("indy"):
      KeyError: 'by_format'

(Not sure if they all have the same error, I just scanned for the first one)

Copy link
Contributor

@ianco ianco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests need to be updated to either configure the verbose format, or to not rely on detailed webhooks

@victorlee0505 victorlee0505 requested a review from ianco March 2, 2023 21:39
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swcurran swcurran merged commit 562a1df into openwallet-foundation:main Mar 6, 2023
@victorlee0505 victorlee0505 deleted the vlee/terse branch March 6, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants