Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8.0-rc0 release updates #2115

Merged
merged 7 commits into from
Feb 10, 2023
Merged

0.8.0-rc0 release updates #2115

merged 7 commits into from
Feb 10, 2023

Conversation

swcurran
Copy link
Contributor

@swcurran swcurran commented Feb 9, 2023

Updates necessary to create a 0.8.0-rc0 release. For this release, the CHANGELOG.md has been update to move the categorized list of Pull Requests from the "0.1.0-rc1" to under this release, and then the PRs since 1.0.0-rc1 were added.

My proposal is that after we release 0.8.0 (final), we follow up with a 0.1.0-rc2 release that is the same as 0.8.0 so that those tracking to the 1.0.0 release can use that. As needed, we can do the same for 0.8.1 / 0.9.0 if needed, but ideally we will get 1.0.0 out the door before those are needed.

@WadeBarnes @ianco @dbluhm -- does that make sense?

Also, please review the note I put into the changelog about the container images (do we have link to put into that paragraph), and if what I state is accurate.

PUBLISHING.md Outdated
Comment on lines 110 to 115
9. Publish a new docker container on Docker Hub
([bcgovimages/aries-cloudagent](https://hub.docker.com/r/bcgovimages/aries-cloudagent/))
by following the README.md instructions to create a PR for the release in the
repository
[https://github.com/bcgov/aries-cloudagent-container](https://github.com/bcgov/aries-cloudagent-container).
Appropriate permissions are required to publish the image.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This process is being replaced by the new GHA Workflows; publish.yml and publish-indy.yml. They are triggered when a release is published. Additional information can be found here; Container Images and Github Actions

The new images will be published here; https://github.com/orgs/hyperledger/packages?repo_name=aries-cloudagent-python. There will be a link to the packages on the repositories main page under Packages.

CHANGELOG.md Outdated
Comment on lines 11 to 13
With this release, a new automated process publishes container
images in the Hyperledger container image repository for this version of ACA-Py
based on both Python 3.6 and 3.9. We recommend using Python 3.9 with ACA-Py.
Copy link
Contributor

@WadeBarnes WadeBarnes Feb 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional information can be found here; Container Images and Github Actions

The new images will be published here; https://github.com/orgs/hyperledger/packages?repo_name=aries-cloudagent-python. There will be a link to the packages on the repository's main page under Packages providing a more direct link once the first images are published.

The images are based on python slim-bullseye images, and are built to support linux/386 (x86), linux/amd64 (x64), and linux/arm64. There are two flavors of image built for each python version. One containing the indy/aries shared libraries only, and one containing the indy/aries shared libraries and the indy-sdk. The images containing the indy-sdk are labeled indy.

The plan with the Python 3.6 images is to only produce them for a limited time to ease side-by-side migration and testing with the existing bcgov/aries-cloudagent-container images.

@WadeBarnes
Copy link
Contributor

My proposal is that after we release 0.8.0 (final), we follow up with a 0.1.0-rc2 release that is the same as 0.8.0 so that those tracking to the 1.0.0 release can use that. As needed, we can do the same for 0.8.1 / 0.9.0 if needed, but ideally we will get 1.0.0 out the door before those are needed.

@WadeBarnes @ianco @dbluhm -- does that make sense?

Yes, that makes sense.

Also, please review the note I put into the changelog about the container images (do we have link to put into that paragraph), and if what I state is accurate.

Reviewed, feedback above.

@ianco
Copy link
Contributor

ianco commented Feb 9, 2023

My proposal is that after we release 0.8.0 (final), we follow up with a 0.1.0-rc2 release that is the same as 0.8.0 so that those tracking to the 1.0.0 release can use that. As needed, we can do the same for 0.8.1 / 0.9.0 if needed, but ideally we will get 1.0.0 out the door before those are needed.
@WadeBarnes @ianco @dbluhm -- does that make sense?

Yes, that makes sense.

Makes sense to me too

@swcurran
Copy link
Contributor Author

swcurran commented Feb 9, 2023

Updates made @WadeBarnes -- please review.

Copy link
Contributor

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small items

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
Signed-off-by: Stephen Curran <[email protected]>
Copy link
Contributor

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way better! Just some missing links to add.

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@swcurran
Copy link
Contributor Author

@WadeBarnes — please check the rendered version to see the links are there.

@WadeBarnes
Copy link
Contributor

@WadeBarnes — please check the rendered version to see the links are there.

Sorry, my oversight.

WadeBarnes
WadeBarnes previously approved these changes Feb 10, 2023
Signed-off-by: Stephen Curran <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swcurran
Copy link
Contributor Author

@WadeBarnes -- please approve again -- added last PR merged (#2112).

Note -- I turned off the new queuing feature as it seem to be hanging. It was used on on 2112, but the required checks (that had already passed) were re-run and didn't complete in time. We'll see about reactivating later...

@swcurran swcurran merged commit 0f66da2 into openwallet-foundation:main Feb 10, 2023
@swcurran swcurran deleted the 0.8.0-rc0 branch February 10, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants