-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.8.0-rc0 release updates #2115
Conversation
Signed-off-by: Stephen Curran <[email protected]>
Signed-off-by: Stephen Curran <[email protected]>
PUBLISHING.md
Outdated
9. Publish a new docker container on Docker Hub | ||
([bcgovimages/aries-cloudagent](https://hub.docker.com/r/bcgovimages/aries-cloudagent/)) | ||
by following the README.md instructions to create a PR for the release in the | ||
repository | ||
[https://github.com/bcgov/aries-cloudagent-container](https://github.com/bcgov/aries-cloudagent-container). | ||
Appropriate permissions are required to publish the image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This process is being replaced by the new GHA Workflows; publish.yml and publish-indy.yml. They are triggered when a release is published. Additional information can be found here; Container Images and Github Actions
The new images will be published here; https://github.com/orgs/hyperledger/packages?repo_name=aries-cloudagent-python. There will be a link to the packages on the repositories main page under Packages.
CHANGELOG.md
Outdated
With this release, a new automated process publishes container | ||
images in the Hyperledger container image repository for this version of ACA-Py | ||
based on both Python 3.6 and 3.9. We recommend using Python 3.9 with ACA-Py. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional information can be found here; Container Images and Github Actions
The new images will be published here; https://github.com/orgs/hyperledger/packages?repo_name=aries-cloudagent-python. There will be a link to the packages on the repository's main page under Packages providing a more direct link once the first images are published.
The images are based on python slim-bullseye
images, and are built to support linux/386
(x86
), linux/amd64
(x64
), and linux/arm64
. There are two flavors of image built for each python version. One containing the indy/aries shared libraries only, and one containing the indy/aries shared libraries and the indy-sdk. The images containing the indy-sdk are labeled indy
.
The plan with the Python 3.6 images is to only produce them for a limited time to ease side-by-side migration and testing with the existing bcgov/aries-cloudagent-container
images.
Yes, that makes sense.
Reviewed, feedback above. |
Makes sense to me too |
Signed-off-by: Stephen Curran <[email protected]>
Signed-off-by: Stephen Curran <[email protected]>
Updates made @WadeBarnes -- please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple small items
Signed-off-by: Stephen Curran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Way better! Just some missing links to add.
@WadeBarnes — please check the rendered version to see the links are there. |
Sorry, my oversight. |
Signed-off-by: Stephen Curran <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
@WadeBarnes -- please approve again -- added last PR merged (#2112). Note -- I turned off the new queuing feature as it seem to be hanging. It was used on on 2112, but the required checks (that had already passed) were re-run and didn't complete in time. We'll see about reactivating later... |
Updates necessary to create a 0.8.0-rc0 release. For this release, the CHANGELOG.md has been update to move the categorized list of Pull Requests from the "0.1.0-rc1" to under this release, and then the PRs since 1.0.0-rc1 were added.
My proposal is that after we release 0.8.0 (final), we follow up with a 0.1.0-rc2 release that is the same as 0.8.0 so that those tracking to the 1.0.0 release can use that. As needed, we can do the same for 0.8.1 / 0.9.0 if needed, but ideally we will get 1.0.0 out the door before those are needed.
@WadeBarnes @ianco @dbluhm -- does that make sense?
Also, please review the note I put into the changelog about the container images (do we have link to put into that paragraph), and if what I state is accurate.