Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating base images from slim-buster to slim-bullseye #2105

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Updating base images from slim-buster to slim-bullseye #2105

merged 1 commit into from
Feb 1, 2023

Conversation

pradeepp88
Copy link
Contributor

Creating this PR to update the base docker images from slim-buster to slim-bullseye version as the slim-buster image is reported to have known vulnerabilities identified by scanning tools like Snyk and Qualys. This relates to #2087 where this is discussed.

Signed-off-by: pradeepp88 [email protected]

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pradeepp88
Copy link
Contributor Author

@WadeBarnes thanks for running the tests. It looks like the integration tests are failing, does this have to do anything with the base Docker images? I see that they are being built from Dockerfile.demo and Dockerfile.bdd, do we need to update them? Please let me know, thanks.

@swcurran
Copy link
Contributor

swcurran commented Feb 1, 2023

Any ideas on the integration test? @ianco — is this an intermittent failure? Do you have a list of tests that fail intermittently so that we can both try to improve them, and know when it is a real failure vs. an intermittent one? Perhaps a doc file we can reference in the repo?

@WadeBarnes
Copy link
Contributor

The failing tests have nothing to do with the changes made here. I've restarted them to see if it's just and intermittent issue.

@WadeBarnes
Copy link
Contributor

It was an intermittent failure.

@WadeBarnes WadeBarnes merged commit cbcaa7d into openwallet-foundation:main Feb 1, 2023
@ianco
Copy link
Contributor

ianco commented Feb 2, 2023

FYI I can run ./scripts/run_tests but if I try ./scripts/run_tests_indy I get an error:

failed to solve with frontend dockerfile.v0: failed to create LLB definition: docker.io/library/python:3.6.13-slim-bullseye: not found

... which is weird because when I run ./scripts/run_tests I see this in the log:

 => [internal] load metadata for docker.io/library/python:3.6.13-slim-buster                                                                                                                                       0.7s
 => [1/6] FROM docker.io/library/python:3.6.13-slim-buster@sha256:c2799d37ac08bcf4c6214e2196b43801acbf90334f565944c4e8b994ed7f7956                                                                                 0.0s

(ok I guess it's not weird, one is using buster and one is trying to use bullseye ...)

@ianco
Copy link
Contributor

ianco commented Feb 2, 2023

FYI I can run ./scripts/run_tests but if I try ./scripts/run_tests_indy I get an error:

If I set PYTHON_VERSION=3.19.6 then it can pull the bullseye image ... @pradeepp88 @WadeBarnes

Not sure what python version we should be targetting?

@WadeBarnes
Copy link
Contributor

@ianco, Python 3.9, and 3.6 for legacy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants