Multi-ledger/Multi-tenant issues #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Costanzo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2022 +/- ##
==========================================
- Coverage 93.51% 93.49% -0.03%
==========================================
Files 539 539
Lines 34625 34637 +12
==========================================
+ Hits 32380 32383 +3
- Misses 2245 2254 +9 |
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: shaangill025 <[email protected]>
…t-python into ianco/multi-issues-2
Signed-off-by: shaangill025 <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -144,7 +144,6 @@ async def setup(self): | |||
| self.root_profile.BACKEND_NAME == "askar" | |||
| and ledger.BACKEND_NAME == "indy-vdr" | |||
| ): | |||
| context.injector.bind_instance(BaseLedger, ledger) | |||
| context.injector.bind_provider( | |||
There was a problem hiding this comment.
For me, it is working even with context.injector.bind_instance(BaseLedger, ledger) included.
shaangill025
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Costanzo [email protected]
Addresses issues: #2002 and #1989
Also fixes a couple of bugs in the alice/faber demo when running multi/multi