Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in run_demo script #1982

Merged

Conversation

pasquale95
Copy link
Contributor

Fixed a bug which prompts out when we try to use the debugging capabilities inside the demo.
The command:

LEDGER_URL=http://dev.greenlight.bcovrin.vonx.io ./run_demo alice --events --no-auto --debug-pycharm-controller-port 5003 --debug-pycharm-agent-port 5004 --debug-pycharm --wallet-type indy

was failing in attaching the debug servers without such fix. Now it works.

It applies also for faber and acme instances.

@swcurran
Copy link
Contributor

@pasquale95 -- the DCO (DCO - Developer Certificate of Origin - https://github.com/apps/dco) was not followed -- e.g. the commit was not signed (git commit -s ...). See the "Details" link above for how to fix. Please do :-).

@pasquale95 pasquale95 force-pushed the feature/fix_debug_options_demo branch from d233b62 to 46c28cc Compare October 18, 2022 17:20
@pasquale95 pasquale95 force-pushed the feature/fix_debug_options_demo branch from 20c8be8 to 2777d02 Compare October 18, 2022 17:23
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pasquale95
Copy link
Contributor Author

@swcurran - thanks for the hint. It should be signed off now 🙂

@codecov-commenter
Copy link

Codecov Report

Merging #1982 (5e567ad) into main (06829f6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1982   +/-   ##
=======================================
  Coverage   93.55%   93.55%           
=======================================
  Files         539      539           
  Lines       34526    34526           
=======================================
  Hits        32300    32300           
  Misses       2226     2226           

@swcurran swcurran merged commit 709a1d4 into openwallet-foundation:main Oct 18, 2022
@pasquale95 pasquale95 deleted the feature/fix_debug_options_demo branch October 19, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants