Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix ACAPY_PROMOTE-AUTHOR-DID flag #1978

Conversation

morrieinmaas
Copy link
Contributor

using underscore instead of hyphen

closes #1965

Signed-off-by: Moriarty [email protected]

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2022

Codecov Report

Merging #1978 (fbb7b31) into main (709a1d4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1978   +/-   ##
=======================================
  Coverage   93.55%   93.55%           
=======================================
  Files         539      539           
  Lines       34526    34526           
=======================================
  Hits        32300    32300           
  Misses       2226     2226           

Moriarty added 2 commits October 17, 2022 16:36
Signed-off-by: Moriarty <[email protected]>
…ithub.com:morrieinmaas/aries-cloudagent-python into fix/1965/arg-parse-auto-promote-author-did
@andrewwhitehead
Copy link
Contributor

It looks like maybe it should be ACAPY_AUTO_PROMOTE_AUTHOR_DID?

@morrieinmaas
Copy link
Contributor Author

It looks like maybe it should be ACAPY_AUTO_PROMOTE_AUTHOR_DID?

Yeah, thx. That sounds more than reasonable.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ianco ianco merged commit a16347d into openwallet-foundation:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Env_var ACAPY_PROMOTE-AUTHOR-DID is invalid with hyphen
5 participants