Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feature discovery support to match RFC, rename endpoint #193

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions aries_cloudagent/messaging/discovery/message_types.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"""Message type identifiers for Protocol Discovery."""
"""Message type identifiers for Feature Discovery."""

MESSAGE_FAMILY = "did:sov:BzCbsNYhMrjHiqZDTUASHg;spec/protocol-discovery/1.0"
MESSAGE_FAMILY = "did:sov:BzCbsNYhMrjHiqZDTUASHg;spec/discover-features/1.0"

DISCLOSE = f"{MESSAGE_FAMILY}/disclose"
QUERY = f"{MESSAGE_FAMILY}/query"
Expand Down
4 changes: 2 additions & 2 deletions aries_cloudagent/messaging/discovery/messages/disclose.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
"""Represents a protocol discovery disclosure message."""
"""Represents a feature discovery disclosure message."""

from typing import Mapping

Expand All @@ -13,7 +13,7 @@


class Disclose(AgentMessage):
"""Represents a protocol discovery disclosure, the response to a query message."""
"""Represents a feature discovery disclosure, the response to a query message."""

class Meta:
"""Disclose metadata."""
Expand Down
4 changes: 2 additions & 2 deletions aries_cloudagent/messaging/discovery/messages/query.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
"""Represents a protocol discovery query message."""
"""Represents a feature discovery query message."""

from marshmallow import fields

Expand All @@ -11,7 +11,7 @@


class Query(AgentMessage):
"""Represents a protocol discovery query.
"""Represents a feature discovery query.

Used for inspecting what message types are supported by the agent.
"""
Expand Down
10 changes: 5 additions & 5 deletions aries_cloudagent/messaging/discovery/routes.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
"""Protocol discovery admin routes."""
"""Feature discovery admin routes."""

from aiohttp import web
from aiohttp_apispec import docs, response_schema
Expand All @@ -9,14 +9,14 @@


class QueryResultSchema(Schema):
"""Result schema for connection list."""
"""Result schema for the protocol list."""

results = fields.Dict(fields.Str(), fields.Dict())


@docs(
tags=["server"],
summary="Query supported protocols",
summary="Query supported features",
parameters=[
{
"name": "query",
Expand All @@ -27,7 +27,7 @@ class QueryResultSchema(Schema):
],
)
@response_schema(QueryResultSchema(), 200)
async def query_protocols(request: web.BaseRequest):
async def query_features(request: web.BaseRequest):
"""
Request handler for inspecting supported protocols.

Expand All @@ -48,4 +48,4 @@ async def query_protocols(request: web.BaseRequest):
async def register(app: web.Application):
"""Register routes."""

app.add_routes([web.get("/protocols", query_protocols)])
app.add_routes([web.get("/features", query_features)])