Pre-populate revoc_reg_id on IssuerRevRegRecord #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1924 +/- ##
==========================================
- Coverage 93.59% 93.59% -0.01%
==========================================
Files 539 539
Lines 34262 34270 +8
==========================================
+ Hits 32069 32076 +7
- Misses 2193 2194 +1 |
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
andrewwhitehead
force-pushed
the
filter-reg-created
branch
from
32a8525 to
2fbcecf
Compare
ianco
approved these changes
Sep 7, 2022
|
Integration tests all pass on my local so I'm merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids having a confusingly blank
revoc_reg_idon the record in theinitstate.Registries in the
initstate are also filtered from the/revocation/registries/createdendpoint.