-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include connection ids in keylist update webhook #1914
Merged
ianco
merged 14 commits into
openwallet-foundation:main
from
sicpa-dlab:fix/conn-id-in-keylist-webhook
Oct 27, 2022
Merged
feat: include connection ids in keylist update webhook #1914
ianco
merged 14 commits into
openwallet-foundation:main
from
sicpa-dlab:fix/conn-id-in-keylist-webhook
Oct 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1914 +/- ##
==========================================
- Coverage 93.55% 93.54% -0.01%
==========================================
Files 539 539
Lines 34526 34564 +38
==========================================
+ Hits 32300 32334 +34
- Misses 2226 2230 +4 |
Signed-off-by: Daniel Bluhm <[email protected]>
This PR doesn't yet address multi-tenancy with a mediator connected to the base wallet. I'll mark this as a draft as I work on that. |
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Necessary for actions specific to just the base wallet for route management tasks Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
ianco
approved these changes
Oct 20, 2022
@dbluhm can you catch this one up with the latest main branch? |
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the connection IDs of the mediated connections. This should make it easier to trigger the next step in a flow (i.e. accept a connection request for one of the connections, if it's in the right state).