Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include connection ids in keylist update webhook #1914

Merged

Conversation

dbluhm
Copy link
Contributor

@dbluhm dbluhm commented Aug 24, 2022

This PR adds the connection IDs of the mediated connections. This should make it easier to trigger the next step in a flow (i.e. accept a connection request for one of the connections, if it's in the right state).

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2022

Codecov Report

Merging #1914 (2332e32) into main (a16347d) will decrease coverage by 0.00%.
The diff coverage is 89.36%.

@@            Coverage Diff             @@
##             main    #1914      +/-   ##
==========================================
- Coverage   93.55%   93.54%   -0.01%     
==========================================
  Files         539      539              
  Lines       34526    34564      +38     
==========================================
+ Hits        32300    32334      +34     
- Misses       2226     2230       +4     

@dbluhm
Copy link
Contributor Author

dbluhm commented Aug 31, 2022

This PR doesn't yet address multi-tenancy with a mediator connected to the base wallet. I'll mark this as a draft as I work on that.

@dbluhm dbluhm marked this pull request as draft August 31, 2022 14:35
@dbluhm dbluhm marked this pull request as ready for review September 26, 2022 14:58
@ianco
Copy link
Contributor

ianco commented Oct 20, 2022

@dbluhm can you catch this one up with the latest main branch?

@ianco ianco enabled auto-merge October 24, 2022 20:11
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ianco ianco merged commit 4696a26 into openwallet-foundation:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants