Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ledger correction code and insert into revocation error handling #1892

Merged
merged 7 commits into from
Aug 17, 2022

Conversation

ianco
Copy link
Contributor

@ianco ianco commented Aug 9, 2022

Addresses issue #1868

@ianco ianco changed the title Fix/revoc error Refactor ledger correction code and insert into revocation error handling Aug 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2022

Codecov Report

Merging #1892 (910aa20) into main (5df3bc8) will decrease coverage by 0.09%.
The diff coverage is 9.41%.

@@            Coverage Diff             @@
##             main    #1892      +/-   ##
==========================================
- Coverage   93.76%   93.67%   -0.10%     
==========================================
  Files         539      539              
  Lines       34105    34144      +39     
==========================================
+ Hits        31978    31983       +5     
- Misses       2127     2161      +34     

@ianco ianco marked this pull request as ready for review August 10, 2022 20:54
shaangill025
shaangill025 previously approved these changes Aug 12, 2022
@ianco ianco marked this pull request as draft August 12, 2022 16:05
@ianco
Copy link
Contributor Author

ianco commented Aug 12, 2022

Per feedback from @WadeBarnes - do a TAA check before allowing the revocation to be processed (same applies to schema and cred def operations)

@ianco ianco marked this pull request as ready for review August 16, 2022 18:53
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ianco ianco merged commit 63f0a74 into openwallet-foundation:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants