Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fully qualified class names for profile managers #1880

Conversation

chumbert
Copy link
Contributor

Fix a small oversight that prevents specifying a qualified class name as
wallet type.

Signed-off-by: Clément Humbert [email protected]

Fix a small oversight that prevents specifying a qualified class name as
wallet type.

Signed-off-by: Clément Humbert <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #1880 (13648d3) into main (4b1fa13) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1880   +/-   ##
=======================================
  Coverage   93.79%   93.79%           
=======================================
  Files         539      539           
  Lines       34079    34079           
=======================================
  Hits        31965    31965           
  Misses       2114     2114           

Copy link
Contributor

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swcurran swcurran merged commit 8e6dce2 into openwallet-foundation:main Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants