-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make base wallet route access configurable #1836
Merged
andrewwhitehead
merged 10 commits into
openwallet-foundation:main
from
dbluhm:feature/configurable-route-access
Jul 20, 2022
Merged
feat: make base wallet route access configurable #1836
andrewwhitehead
merged 10 commits into
openwallet-foundation:main
from
dbluhm:feature/configurable-route-access
Jul 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1836 +/- ##
=======================================
Coverage 93.72% 93.73%
=======================================
Files 536 536
Lines 34020 34038 +18
=======================================
+ Hits 31886 31904 +18
Misses 2134 2134 |
burdettadam
previously approved these changes
Jun 22, 2022
@dbluhm -- can you please look into the Circle-CI failure? Thanks. |
Signed-off-by: Daniel Bluhm <[email protected]>
This PR should be ready for review now. |
andrewwhitehead
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding admin routes through plugins, it makes sense for the plugin to be able to specify that those routes should be accessible to the base wallet when appropriate.