Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make base wallet route access configurable #1836

Conversation

dbluhm
Copy link
Contributor

@dbluhm dbluhm commented Jun 22, 2022

When adding admin routes through plugins, it makes sense for the plugin to be able to specify that those routes should be accessible to the base wallet when appropriate.

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2022

Codecov Report

Merging #1836 (6bf8384) into main (ad1cad3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1836   +/-   ##
=======================================
  Coverage   93.72%   93.73%           
=======================================
  Files         536      536           
  Lines       34020    34038   +18     
=======================================
+ Hits        31886    31904   +18     
  Misses       2134     2134           

burdettadam
burdettadam previously approved these changes Jun 22, 2022
@swcurran
Copy link
Contributor

@dbluhm -- can you please look into the Circle-CI failure? Thanks.

@dbluhm
Copy link
Contributor Author

dbluhm commented Jul 14, 2022

This PR should be ready for review now.

@dbluhm dbluhm requested a review from andrewwhitehead July 20, 2022 14:06
@andrewwhitehead andrewwhitehead merged commit b6c1f1f into openwallet-foundation:main Jul 20, 2022
@dbluhm dbluhm deleted the feature/configurable-route-access branch September 17, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants