-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IssuerCredRevRecord state update on revocation publish #1827
Fix IssuerCredRevRecord state update on revocation publish #1827
Conversation
@shaangill025 @ianco --- would really appreciate your review and assessment of this change. Working? |
Looks like Github webhooks are currently in degraded status |
…test Signed-off-by: Andrew Whitehead <[email protected]>
dc8b5a3
to
213d2fa
Compare
Codecov Report
@@ Coverage Diff @@
## main #1827 +/- ##
==========================================
+ Coverage 93.70% 93.71% +0.01%
==========================================
Files 534 534
Lines 33871 33879 +8
==========================================
+ Hits 31738 31750 +12
+ Misses 2133 2129 -4 |
This comment was marked as resolved.
This comment was marked as resolved.
If you're running with a ledger that requires TAA acceptance you need to run faber with |
|
Tested with Alice-Faber demo, now after revocation and publication, the credential state is |
I think this is part of the test. The ledger transaction is rejected, but it checks the revoked state of the credential anyway. |
That's correct, the test puts the wallet into a state where the ledger write will fail, to test the recovery method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes #1823 broken in #1804
Ran against integration tests T002-TAA and T003-TAA which were previously failing.