Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing webhook handler #1816

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Conversation

ianco
Copy link
Contributor

@ianco ianco commented Jun 16, 2022

Signed-off-by: Ian Costanzo [email protected]

Signed-off-by: Ian Costanzo <[email protected]>
@ianco ianco requested a review from swcurran June 16, 2022 13:45
@swcurran
Copy link
Contributor

Awesome! This fixes #1815 .

@ianco -- the handler is printing on the terminal "handle_out_of_band()" after the QR code prints. Is that normal for handlers? Do they also display that by default? It looked odd to me.

Other than that -- looked good.

@codecov-commenter
Copy link

Codecov Report

Merging #1816 (3c12f31) into main (c308329) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1816   +/-   ##
=======================================
  Coverage   93.70%   93.70%           
=======================================
  Files         534      534           
  Lines       33871    33871           
=======================================
  Hits        31738    31738           
  Misses       2133     2133           

Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants