-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of revocation registry creation #1813
Refactoring of revocation registry creation #1813
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1813 +/- ##
==========================================
- Coverage 93.72% 93.71% -0.02%
==========================================
Files 536 536
Lines 34015 33998 -17
==========================================
- Hits 31881 31861 -20
- Misses 2134 2137 +3 |
4dc3188
to
7e26ba6
Compare
I'm going to add another update and resync this shortly. |
6d65a25
to
a6357fd
Compare
960d611
to
fadb9cc
Compare
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
…ansaction endorsement Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
c6946f2
to
8bfa60b
Compare
The integration test passes when I run locally :-( I'm going to try just re-running the tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, all tests pass locally
This updates the revocation registry initialization process.
Previously, an event was fired using
profile.notify
, which led to anIssuerRevRegRecord
being created and the associated revocation registry being generated. Now, theIssuerRevRegRecord
is created first, and then the event is fired, which leads to the registry generation. This allows the detection of a registry in progress and helps to avoid multiple revocation registries being created in parallel for the same credential definition.Also, the tails file is now uploaded after the registry definition is posted and before the first entry is posted, instead of after the first entry is posted. This ensures that the registry doesn't enter the ACTIVE state until after the tails file is publicly available.