Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of revocation registry creation #1813

Merged
merged 6 commits into from
Aug 8, 2022

Conversation

andrewwhitehead
Copy link
Contributor

This updates the revocation registry initialization process.

Previously, an event was fired using profile.notify, which led to an IssuerRevRegRecord being created and the associated revocation registry being generated. Now, the IssuerRevRegRecord is created first, and then the event is fired, which leads to the registry generation. This allows the detection of a registry in progress and helps to avoid multiple revocation registries being created in parallel for the same credential definition.

Also, the tails file is now uploaded after the registry definition is posted and before the first entry is posted, instead of after the first entry is posted. This ensures that the registry doesn't enter the ACTIVE state until after the tails file is publicly available.

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2022

Codecov Report

Merging #1813 (960d611) into main (1673245) will decrease coverage by 0.01%.
The diff coverage is 57.03%.

@@            Coverage Diff             @@
##             main    #1813      +/-   ##
==========================================
- Coverage   93.72%   93.71%   -0.02%     
==========================================
  Files         536      536              
  Lines       34015    33998      -17     
==========================================
- Hits        31881    31861      -20     
- Misses       2134     2137       +3     

@andrewwhitehead
Copy link
Contributor Author

I'm going to add another update and resync this shortly.

@andrewwhitehead andrewwhitehead force-pushed the fix/revoc-tails branch 5 times, most recently from 6d65a25 to a6357fd Compare June 27, 2022 16:08
@andrewwhitehead andrewwhitehead force-pushed the fix/revoc-tails branch 2 times, most recently from 960d611 to fadb9cc Compare July 4, 2022 16:09
@andrewwhitehead andrewwhitehead force-pushed the fix/revoc-tails branch 2 times, most recently from c6946f2 to 8bfa60b Compare July 22, 2022 16:07
@ianco
Copy link
Contributor

ianco commented Aug 8, 2022

The integration test passes when I run locally :-( I'm going to try just re-running the tests

Copy link
Contributor

@ianco ianco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all tests pass locally

@ianco ianco merged commit d407c48 into openwallet-foundation:main Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants