[#1745] Fetch from --genesis-url likely to fail in composed container…

[tdiesler]

… setup

Signed-off-by: Thomas Diesler [email protected]

[TimoGlastra]

As this is more of a VON-network thing, maybe you can make the acapy service dependant on the webserver service (https://docs.docker.com/compose/compose-file/compose-file-v3/#depends_on) and add a healthcheck to the webserver service that pings whether the container is online (https://docs.docker.com/compose/compose-file/compose-file-v3/#healthcheck)

[tdiesler]

depends_on does not work, because liveness does not imply readiness. IMHO, it is an ACA-Py issue, because this project requires that the genesis information becomes available within 5sec of process startup - which is a bold assumption.

If genesis becomes available within 5sec, the proposed change has no effect. If genesis doesn't become available at all, the process would not fail before the 20sec timeout, which might not be ideal. An improved solution might be an additional config parameter that tells ACA-Py how long to wait for dependent components (i.e. Ledger + Tails Server)

[codecov-commenter]

Codecov Report

Merging #1746 (2ea9393) into main (ff68284) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1746   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files         528      528           
  Lines       33142    33142           
=======================================
  Hits        31564    31564           
  Misses       1578     1578