Use provided connection_id if provided #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Costanzo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1726 +/- ##
==========================================
- Coverage 95.26% 95.25% -0.01%
==========================================
Files 528 528
Lines 33109 33111 +2
==========================================
Hits 31541 31541
- Misses 1568 1570 +2 |
Signed-off-by: Ian Costanzo <[email protected]>
andrewwhitehead
approved these changes
Apr 12, 2022
|
I meant to ask before...I notice the variable is called "connection_id", but should it be "endorser_connection_id" to be clearly about the purpose? Or am I just not understanding what this is for... 🤡 |
Yah you're right, same issue on all the api's that support endorsement. (On another note if you use all the aca-py parameters you don't need to use this field anyways) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Costanzo [email protected]
See issue #1703