Fix: present-proof v2 send-proposal [issue#1474]

aries_cloudagent/protocols/present_proof/v2_0/formats/indy/handler.py

@@ -114,21 +114,26 @@ async def create_bound_request(
         indy_proof_request = pres_ex_record.pres_proposal.attachment(
             IndyPresExchangeHandler.format
         )
-        indy_proof_request["name"] = request_data.get("name") or "proof-request"
-        indy_proof_request["version"] = request_data.get("version") or "1.0"
-        indy_proof_request["nonce"] = (
-            request_data.get("nonce") or await generate_pr_nonce()
-        )
+        if request_data:
+            indy_proof_request["name"] = request_data.get("name", "proof-request")
+            indy_proof_request["version"] = request_data.get("version", "1.0")
+            indy_proof_request["nonce"] = (
+                request_data.get("nonce") or await generate_pr_nonce()
+            )
+        else:
+            indy_proof_request["name"] = "proof-request"
+            indy_proof_request["version"] = "1.0"
+            indy_proof_request["nonce"] = await generate_pr_nonce()
         return self.get_format_data(PRES_20_REQUEST, indy_proof_request)
 
     async def create_pres(
         self,
         pres_ex_record: V20PresExRecord,
-        request_data: dict = {},
+        request_data: dict = None,
     ) -> Tuple[V20PresFormat, AttachDecorator]:
         """Create a presentation."""
         requested_credentials = {}
-        if request_data == {}:
+        if not request_data:
             try:
                 proof_request = pres_ex_record.pres_request
                 indy_proof_request = proof_request.attachment(

aries_cloudagent/protocols/present_proof/v2_0/tests/test_manager.py

@@ -553,7 +553,7 @@ async def test_receive_proposal(self):
 
             assert px_rec.state == V20PresExRecord.STATE_PROPOSAL_RECEIVED
 
-    async def test_create_bound_request(self):
+    async def test_create_bound_request_a(self):
         comment = "comment"
 
         proposal = V20PresProposal(
@@ -587,6 +587,34 @@ async def test_create_bound_request(self):
         assert ret_px_rec is px_rec
         px_rec.save.assert_called_once()
 
+    async def test_create_bound_request_b(self):
+        comment = "comment"
+
+        proposal = V20PresProposal(
+            formats=[
+                V20PresFormat(
+                    attach_id="indy",
+                    format_=ATTACHMENT_FORMAT[PRES_20_PROPOSAL][
+                        V20PresFormat.Format.INDY.api
+                    ],
+                )
+            ],
+            proposals_attach=[
+                AttachDecorator.data_base64(INDY_PROOF_REQ_NAME, ident="indy")
+            ],
+        )
+        px_rec = V20PresExRecord(
+            pres_proposal=proposal.serialize(),
+            role=V20PresExRecord.ROLE_VERIFIER,
+        )
+        px_rec.save = async_mock.CoroutineMock()
+        (ret_px_rec, pres_req_msg) = await self.manager.create_bound_request(
+            pres_ex_record=px_rec,
+            comment=comment,
+        )
+        assert ret_px_rec is px_rec
+        px_rec.save.assert_called_once()
+
     async def test_create_bound_request_no_format(self):
         px_rec = V20PresExRecord(
             pres_proposal=V20PresProposal(

requirements.bbs.txt

@@ -1 +1 @@
-ursa-bbs-signatures==1.0.1
+ursa-bbs-signatures~=1.0.1