Fixes and cleanups for issue-credential 1.0 #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andrewwhitehead
commented
Feb 5, 2022
andrewwhitehead
commented
- Improve logging
- Use transactions for better state management under Askar
- Add more checks around the credential exchange state in case of repeated messages
Codecov Report
@@ Coverage Diff @@
## main #1619 +/- ##
==========================================
- Coverage 95.71% 95.67% -0.05%
==========================================
Files 528 528
Lines 32590 32657 +67
==========================================
+ Hits 31194 31243 +49
- Misses 1396 1414 +18 |
andrewwhitehead
force-pushed
the
fix/issue-cred-sessions
branch
from
126b3bd to
6642ff4
Compare
andrewwhitehead
force-pushed
the
fix/issue-cred-sessions
branch
from
6642ff4 to
41fb940
Compare
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
…dd for_update option to retrieval methods Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
andrewwhitehead
force-pushed
the
fix/issue-cred-sessions
branch
from
41fb940 to
d7f248f
Compare
ianco
approved these changes
Mar 2, 2022
|
(had a successful run with |
This was referenced Mar 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.