Add fix for #1575 to allow OPTIONS method to work with x-api-key #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k when x-api-key is configured Signed-off-by: john court <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1576 +/- ##
=======================================
Coverage 95.76% 95.76%
=======================================
Files 527 527
Lines 32312 32312
=======================================
+ Hits 30942 30943 +1
+ Misses 1370 1369 -1 |
Signed-off-by: john court <[email protected]>
Signed-off-by: john court <[email protected]>
ianco
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow OPTIONS method used by browsers to implement CORS checks to be serviced without requiring the x-api-key to be present in the request. Also added a test case for same.
Signed-off-by: john court [email protected]