Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove required dependencies from multi-ledger code #1550

Merged

Conversation

andrewwhitehead
Copy link
Contributor

Also adjusts the return value from get_ledger_for_identifier for consistency.

Fixes #1549

@swcurran swcurran requested a review from dbluhm December 11, 2021 00:01
@swcurran
Copy link
Contributor

@dbluhm -- can you please do the reviewing and testing of this, since you have the use case to try?

Others are welcome to jump in. A lot more code changed than expected :-).

@dbluhm
Copy link
Contributor

dbluhm commented Dec 11, 2021

@dbluhm -- can you please do the reviewing and testing of this, since you have the use case to try?

Others are welcome to jump in. A lot more code changed than expected :-).

Will do, thanks for working to address this one!

…esult format for get_ledger_for_identifier method

Signed-off-by: Andrew Whitehead <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #1550 (04be014) into main (7422b3c) will increase coverage by 0.06%.
The diff coverage is 92.45%.

@@            Coverage Diff             @@
##             main    #1550      +/-   ##
==========================================
+ Coverage   95.69%   95.75%   +0.06%     
==========================================
  Files         527      527              
  Lines       32400    32306      -94     
==========================================
- Hits        31005    30936      -69     
+ Misses       1395     1370      -25     

Copy link
Contributor

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that this fixes #1549. On top of that, the other changes for consistency look good.

@swcurran swcurran merged commit 6aceb54 into openwallet-foundation:main Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Askar must be installed
4 participants