Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added documentation for wallet storage databases #1523

Merged
merged 6 commits into from
Dec 1, 2021
Merged

added documentation for wallet storage databases #1523

merged 6 commits into from
Dec 1, 2021

Conversation

chriamue
Copy link
Contributor

@chriamue chriamue commented Nov 29, 2021 •
edited
Loading

  • SQlite
  • PostgreDB
  • Link in other documentation
  • Docker Compose example

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2021 •
edited
Loading

Codecov Report

Merging #1523 (1e324c7) into main (25be55f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1523   +/-   ##
=======================================
  Coverage   95.70%   95.70%           
=======================================
  Files         521      521           
  Lines       32191    32191           
=======================================
  Hits        30810    30810           
  Misses       1381     1381

@chriamue
Copy link
Contributor Author

Is wallet-key used in storage type postgres?

@chriamue chriamue changed the title added documentation for sqlite database as wallet storage added documentation for wallet storage databases Nov 29, 2021
@TimoGlastra
Copy link
Contributor

Is wallet-key used in storage type postgres?

Yes!

@TimoGlastra
Copy link
Contributor

@swcurran / @ianco might be good to extract all markdown docs into a separate directory to make it a bit more neatly arranged

@swcurran
Copy link
Contributor

Agreed... I'll open a separate issue on that and take it on. I'll combine it with the ability to review the docs on the read-the-docs site. A good chance for a docs review.

@chriamue chriamue marked this pull request as ready for review December 1, 2021 07:31
@ianco ianco enabled auto-merge December 1, 2021 20:42
@ianco ianco merged commit b02db9c into openwallet-foundation:main Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianco ianco ianco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chriamue @codecov-commenter @TimoGlastra @swcurran @ianco