Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify instructions in Acme Controller Workshop #1482

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions demo/AcmeDemoWorkshop.md
Original file line number Diff line number Diff line change
Expand Up @@ -172,16 +172,18 @@ We're going to do option (a), but you can try to implement option (b) as homewor
First though we need to register a schema and credential definition. Find this code:

``` python
# TODO: Create schema
# acme_schema_name = "employee id schema"
# acme_schema_attrs = ["employee_id", "name", "date", "position"]
await acme_agent.initialize(
the_agent=agent,
# schema_name=acme_schema_name,
# schema_attrs=acme_schema_attrs,
)

# TODO publish schema and cred def
```

... and just remove the ```TODO ```, then uncommment the rest. Easy, no?
... and uncomment the code lines. Replace the ```# TODO``` comment with the following code:

``` python
with log_timer("Publish schema and cred def duration:"):
Expand All @@ -194,7 +196,8 @@ First though we need to register a schema and credential definition. Find this
random.randint(1, 101),
)
)
# (schema_id, cred_def_id) = await agent.register_schema_and_creddef(
# register schema and cred def
(schema_id, cred_def_id) = await agent.register_schema_and_creddef(
"employee id schema",
version,
["employee_id", "name", "date", "position"],
Expand Down
3 changes: 2 additions & 1 deletion demo/runners/acme.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,14 +136,15 @@ async def main(args):
)

acme_agent.public_did = True
# TODO: Create schema
# acme_schema_name = "employee id schema"
# acme_schema_attrs = ["employee_id", "name", "date", "position"]
await acme_agent.initialize(
the_agent=agent,
# schema_name=acme_schema_name,
# schema_attrs=acme_schema_attrs,
)

# TODO publish schema and cred def

# generate an invitation for Alice
await acme_agent.generate_invitation(display_qr=True, wait=True)
Expand Down