Endorser protocol event bus refactor #1431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1431 +/- ##
==========================================
- Coverage 94.59% 94.53% -0.07%
==========================================
Files 483 485 +2
Lines 29664 29712 +48
==========================================
+ Hits 28061 28087 +26
- Misses 1603 1625 +22 |
ianco
force-pushed
the
endorser_protocol
branch
from
4dfbd10 to
fec69f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a function to the protocol to (potentially) subscribe to events
Register/subscribe to all protocol events on aca-py startup
Add meta-data to the endorser transaction record to pass information downstream (e.g. save cred def revocation info so it's available to the revocation registry tasks)
Code refactor is WIP
(see https://hackmd.io/51flx8CVS1ypyOjEqVl1tg?view#Implementation-Details)