-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Indy Ledger support and State Proof verification #1425
Multiple Indy Ledger support and State Proof verification #1425
Conversation
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
…t-python into mult_indy_network_support
…t-python into mult_indy_network_support
Signed-off-by: Shaanjot Gill <[email protected]>
…t-python into mult_indy_network_support
Signed-off-by: Shaanjot Gill <[email protected]>
…t-python into mult_indy_network_support
Signed-off-by: Shaanjot Gill <[email protected]>
…t-python into mult_indy_network_support
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
…t-python into mult_indy_network_support
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @shaangill025 overall this looks pretty good. I haven't done a deep dive yet though.
Once thing that would be nice is a document describing how the multi-ledger support works, or how to use it, for example:
- how to I define multiple ledgers? (I know there is a hackmd but should prob be a doc in the github repo)
- what do I need to do for read vs write? (I assume the verifier has to be able to auto-select the ledger based on received proofs, but what about the issuer?)
- can you add/remove ledgers at runtime or only on startup?
- what happens if I restart an agent with a different set of ledgers than previously? (note that data in the wallet is ledger-specific, for example data associated with credential definitions)
- any impact on other functions, such as the endorser protocol (may need a different endorser for different ledgers)
See the docs for functions like multitenancy, mediation, endorser, for example.
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
…t-python into mult_indy_network_support
…ill025/aries-cloudagent-python into mult_indy_network_support
@ianco It is ready for review. I have removed the ability to update the |
Signed-off-by: Shaanjot Gill <[email protected]>
…ill025/aries-cloudagent-python into mult_indy_network_support
Signed-off-by: Shaanjot Gill <[email protected]>
…ill025/aries-cloudagent-python into mult_indy_network_support
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Fix faber demo to run in multi-ledger mode
…t-python into mult_indy_network_support
…ill025/aries-cloudagent-python into mult_indy_network_support
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
w00t! Awesome stuff, @shaangill025 ! |
./Multiledger.md
(this PR).