Open askar sessions only on demand - Connections #1424
Conversation
Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: arin.hlaj <[email protected]> Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: arin.hlaj <[email protected]> Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: Andraž Cuderman <[email protected]>
aries_cloudagent/core/in_memory.py
Outdated
| @@ -49,6 +49,11 @@ def bind_providers(self): | |||
| ), | |||
| ) | |||
|
|
|||
| def _init_context(self): | |||
There was a problem hiding this comment.
I don't see why this is necessary, it's already performed for the session when that is created?
There was a problem hiding this comment.
This is performed on the session only when test_session function is called. But in this case we call test_profile.
Another option would be to call init_context every time we create a new session (in constructor) but I think used approach is clearer since in non test environment, dependencies are also bound to the profile context.
There was a problem hiding this comment.
The session must be awaited or used as an async context manager. When this happens the _setup method is called, which calls _init_context on the session. If the session has not been initialized this way then it is not technically 'open' (the in-memory backend is more forgiving about this currently). I think that adding this workaround is just masking the issue.
There was a problem hiding this comment.
Thanks for the explanation. We removed _init_context on the profile and created sessions with async context.
|
Thanks! Looks very thorough in general |
Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: Andraž Cuderman <[email protected]>
acuderman
force-pushed
the
feat-IDENT-3371-askar-sessions-demand-connections
branch
from
fa9b363 to
df4e33e
Compare
This PR fixes the connections part of the #1417 issue.