Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connectionless proof demo #1395

Merged
merged 11 commits into from
Sep 8, 2021

Conversation

ianco
Copy link
Contributor

@ianco ianco commented Sep 3, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #1395 (58bd7a5) into main (f70e454) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1395   +/-   ##
=======================================
  Coverage   95.28%   95.28%           
=======================================
  Files         476      476           
  Lines       29034    29034           
=======================================
  Hits        27664    27664           
  Misses       1370     1370           

Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
@ianco ianco requested a review from swcurran September 7, 2021 19:27
@ianco ianco marked this pull request as ready for review September 7, 2021 19:27
@ianco
Copy link
Contributor Author

ianco commented Sep 7, 2021

Also fixes issue #1291

Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things that would be nice to change, but not holding it up because of them:

  1. It would be nice if Alice accepted the invitation and processed the connectionless proof, either be making the existing “new invitation” fancier or by adding a new option.

  2. It would be nice that instead of hard-coding the predicate dateIn value, that you showed the calculation to get the date — e.g. convert_to_dateInt(now() -years(21)).

@ianco ianco merged commit 32e7014 into openwallet-foundation:main Sep 8, 2021
@ianco
Copy link
Contributor Author

ianco commented Sep 8, 2021

A couple of things that would be nice to change, but not holding it up because of them:

  1. It would be nice if Alice accepted the invitation and processed the connectionless proof, either be making the existing “new invitation” fancier or by adding a new option.
  2. It would be nice that instead of hard-coding the predicate dateIn value, that you showed the calculation to get the date — e.g. convert_to_dateInt(now() -years(21)).

Re #2, I'll update in my next PR.

Re #1, I'm not sure what this means, since it's a connectionless proof ...

@swcurran
Copy link
Contributor

swcurran commented Sep 8, 2021

Re: 1 — A connection-less proof is just an invitation (plain-text) given to an any agent to which they respond (if they want, of course) with a proof. Alice could be that agent — separate from her existing connection with Faber. So her agent just gets the invitation with the proof request and responds to it using the data in the invitation, without really knowing who is asking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants