-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connectionless proof demo #1395
Connectionless proof demo #1395
Conversation
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1395 +/- ##
=======================================
Coverage 95.28% 95.28%
=======================================
Files 476 476
Lines 29034 29034
=======================================
Hits 27664 27664
Misses 1370 1370 |
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Also fixes issue #1291 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of things that would be nice to change, but not holding it up because of them:
-
It would be nice if Alice accepted the invitation and processed the connectionless proof, either be making the existing “new invitation” fancier or by adding a new option.
-
It would be nice that instead of hard-coding the predicate dateIn value, that you showed the calculation to get the date — e.g. convert_to_dateInt(now() -years(21)).
Re #2, I'll update in my next PR. Re #1, I'm not sure what this means, since it's a connectionless proof ... |
Re: 1 — A connection-less proof is just an invitation (plain-text) given to an any agent to which they respond (if they want, of course) with a proof. Alice could be that agent — separate from her existing connection with Faber. So her agent just gets the invitation with the proof request and responds to it using the data in the invitation, without really knowing who is asking. |
No description provided.