Update Alice/Faber demo to include json-ld credentials and proofs #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1235 +/- ##
==========================================
- Coverage 98.21% 98.20% -0.02%
==========================================
Files 466 466
Lines 26840 26853 +13
==========================================
+ Hits 26362 26372 +10
- Misses 478 481 +3 |
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
TimoGlastra
reviewed
Jun 15, 2021
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
| # Add BBS context if not present yet | ||
| if ( | ||
| detail.options.proof_type == BbsBlsSignature2020.signature_type | ||
| and SECURITY_CONTEXT_BBS_URL not in detail.credential.context_urls | ||
| ): | ||
| detail.credential.add_context(SECURITY_CONTEXT_BBS_URL) | ||
|
|
||
| # add holder_did as credentialSubject.id (if provided) | ||
| if holder_did and holder_did.startswith("did:key"): |
There was a problem hiding this comment.
I don't understand why this would be limited to did:key, shouldn't any DID be treated the same here?
andrewwhitehead
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still work in progress - working on updates to the documentation, and adding BDD tests. Logic in the demo is pretty straightforward and will be enhanced.
The holder
credentialSubject.id(in the credential) must be specified in order for the presentation to validate. I have added this as an optional parameter to the/create-requestendpoint, if the holder supplied a did then it will be inserted into the credential request as thecredentialSubject.id. (Not sure if this is the best approach @TimoGlastra @andrewwhitehead @swcurran )